Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: build a multi-arch main image#11668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
matifali wants to merge12 commits intomainfromdepot-main
Closed

ci: build a multi-arch main image#11668

matifali wants to merge12 commits intomainfromdepot-main

Conversation

matifali
Copy link
Member

@matifalimatifali commentedJan 17, 2024
edited
Loading

2nd attempt at#11544
Additionally, we can move the coder build to Dockerfile and build with dpot.dev 16 core 32 GB builder.

@matifalimatifali marked this pull request as ready for reviewJanuary 17, 2024 15:58
@deansheather
Copy link
Member

Additionally, we can move the coder build to Dockerfile and build with dpot.dev 16 core 32 GB builder.

I think we should leave it how it is. We want to ship the same binary everywhere, so it'd be weird to rebuild it in the Docker image compared to the one we ship as a raw binary on github releases.

matifali reacted with thumbs up emoji

@matifali
Copy link
MemberAuthor

@deansheather, which one do you prefer?#11544 or this one?

@deansheather
Copy link
Member

@matifali The other one, you shouldn't need depot to build these. We only use depot to build the "base" image, which is built on every release and on a weekly basis and pushed to the base repo. The reason we need depot to build that is because it hasRUN statements which cannot be cross-built from amd64. The non-base Dockerfile doesn't containRUN statements and just hasCOPY and other statements that can be cross-built. So you should just do that.

@matifali
Copy link
MemberAuthor

matifali commentedJan 17, 2024
edited
Loading

@deansheather I understand, but our current approach requires pushing individual arch images to the registry and then pulling those back, creating a manifest, and pushing the manifest. Depot allows removing all that and makes it super easy to push multi-arch images.

@matifali
Copy link
MemberAuthor

After discussing with@deansheather, I am closing in favor of#11544. We do not benefit from the depot.dev as our multi-archDockerfile does not have anyRUN commands.

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 17, 2024
@github-actionsgithub-actionsbot deleted the depot-main branchJuly 18, 2024 00:05
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherAwaiting requested review from deansheather

@johnstcnjohnstcnAwaiting requested review from johnstcn

Assignees

@matifalimatifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@matifali@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp