Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: allow ports in wildcard url configuration#11657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 5 commits intomainfromstevenmasley/wildcard_url_with_port
Jan 18, 2024

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedJan 17, 2024•
edited
Loading

This just forwards the port to the ui that generates urls.
Our existing parsing + regex already supported ports for
subdomain app requests.

Closes#8189

Tested with subdomain apps and port forwarding.

Remanent of the past

We have this old assumption that apphost and accessurl are on the same port.

host:=api.AppHostname
ifhost!=""&&api.AccessURL.Port()!="" {
host+=fmt.Sprintf(":%s",api.AccessURL.Port())
}

This might now not be the case. For backwards compatibility, we have to keep this here, but it could be a problem if the access url has a port, and the wildcard domain does not.

Workspace proxies?

Workspace proxies do not have this "port inheritance" thing going on. I think the port inheritance is a mistake, but for backwards compatibility, it has to be kept on the primary.

@EmyrkGraphite App
Copy link
MemberAuthor

Emyrk commentedJan 17, 2024•
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@Emyrk and the rest of your teammates onGraphiteGraphite

Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Needs tests for actual serving too, and the frontend should be checked to ensure it functions with this

@Emyrk
Copy link
MemberAuthor

@deansheather I checked the frontend. I'll add some tests.

@EmyrkEmyrk added the release/breakingThis label is applied to PRs to detect breaking changes as part of the release process labelJan 17, 2024
@EmyrkEmyrk changed the titlefix: allow ports in wildcard url configurationfix!: allow ports in wildcard url configurationJan 17, 2024
@EmyrkEmyrk changed the titlefix!: allow ports in wildcard url configurationfix: allow ports in wildcard url configurationJan 17, 2024
@EmyrkEmyrk removed the release/breakingThis label is applied to PRs to detect breaking changes as part of the release process labelJan 17, 2024
Base automatically changed fromstevenmasley/ports_in_wildcard tomainJanuary 17, 2024 16:41
This just forwards the port to the ui that generates urls.Our existing parsing + regex already supported ports forsubdomain app requests.
@EmyrkEmyrkforce-pushed thestevenmasley/wildcard_url_with_port branch froma673da8 toed4410cCompareJanuary 17, 2024 16:44
@EmyrkEmyrk marked this pull request as ready for reviewJanuary 17, 2024 17:11
@EmyrkEmyrk merged commit6bb1a34 intomainJan 18, 2024
@EmyrkEmyrk deleted the stevenmasley/wildcard_url_with_port branchJanuary 18, 2024 15:44
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port is missing when port-forwarding via Dashboard
2 participants
@Emyrk@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp