- Notifications
You must be signed in to change notification settings - Fork928
feat(cli/ssh): allow multiple remote forwards and allow missing local file#11648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
mafredri merged 4 commits intomainfrommafredri/feat-cli-ssh-allow-multiple-remote-forwardsJan 19, 2024
Merged
feat(cli/ssh): allow multiple remote forwards and allow missing local file#11648
mafredri merged 4 commits intomainfrommafredri/feat-cli-ssh-allow-multiple-remote-forwardsJan 19, 2024
+127 −32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
0e66663 toc2dea4aComparespikecurtis approved these changesJan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would be nice to have a test case that specifies multiple-R
8da5d2c tof752bb6Comparef752bb6 tof99f490CompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
While working on#11631 I found myself needing the ability to do multiple remote forwards to compare the behavior between our client and OpenSSH. Created a PR for this since I think it's a useful addition.
Similar to OpenSSH, we no longer require the presence of the local file. Its presence is only relevant at exactly the moment someone tries to connect to it. Likewise, we don't enforced the presence at runtime, so to achieve this you'd have to fool the SSH command during init, and then you can do whatever you want with the socket afterwards.