- Notifications
You must be signed in to change notification settings - Fork924
feat: exposeowner_name incoder_workspace resource#11639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Names are hard!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| // UserRealNameValid returns whether the input string is a valid real user name. | ||
| func UserRealNameValid(str string) error { | ||
| if len(str) > 128 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What's the motivation for this limit? Hubert will be sad:https://www.guinnessworldrecords.com/world-records/67285-longest-personal-name
I think it's unlikely we'll hit this, but arbitrary limits have a way of making people sad (think email regex). We should at least document this decision a bit better. Should length also be enforced in the DB side?
PS. If we're thinking about frontend, they could always use ellipse over there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would expect we don't want to allow someone to fill up the database with a name that's gigabytes in size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, I understand that risk could be a concern, I was specifically thinking aboutthis limit (128), though. Seems on the smaller to just be a safety-net. And if we're really worried about this case, I do think database limits would be a good idea, otherwise we'll always run the risk of introducing new holes. And I'd be surprised if we didn't have some gaps in this defense elsewhere currently as well 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The form Mr. Hubert used, HUBERT BLAINE WOLFESCHLEGELSTEINHAUSENBERGERDORFF SR, is within the limit!
The original use case for this feature is to populate all places where UI or CLI can render it, like Git commiter/message. I'm sure that Hubert Blain Wolf... will crash UIs in many different places, so I would stick to the artificial limit.
Anyway, we can always disable the limit. The other way round might be hard to do as we might need to chop some names...
I do think database limits would be a good idea, otherwise we'll always run the risk of introducing new holes. And I'd be surprised if we didn't have some gaps in this defense elsewhere currently as well 😄.
This is valid risk, and I wouldn't like to enable another gate to pump bytes into the database.
| {"Hector Ó hEochagáin", true}, | ||
| {"Małgorzata Kalinowska-Iszkowska", true}, | ||
| {"成龍", true}, | ||
| {". .", true}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks like a smiley, I approve! 👀
| } | ||
| if strings.TrimSpace(str) != str { | ||
| return xerrors.New("must not have leading or trailing white spaces") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Happened to catch my eye, whitespace is uncountable, so we drops. Alt: whitespace characterS.
| returnxerrors.New("must not have leading or trailingwhite spaces") | |
| returnxerrors.New("must not have leading or trailingwhitespace") |
Not sure about having white space in whitespace, though. Both could be correct 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Uh oh!
There was an error while loading.Please reload this page.
Related:#9883
This PR modifies the
usersdatabase table to store the workspace owner's name (first name, last name).Follow-up: