- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: use tailnet v2 API for coordination#11638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
spikecurtis commentedJan 16, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
4177202 to04e3985Compare80e59bd tofe63f6aCompare04e3985 to64caaacCompare9a1e2eb to2f11961Compare64caaac to2bced78Compare2f11961 toe611c3cCompare2bced78 toafd20a0Comparee611c3c tofba56d1Compareafd20a0 to0b9455cComparefba56d1 to02287a9Compare02287a9 to8156019Compare8156019 to8a045b0Compare8a045b0 to6ef3db5Compare
coadler left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good. Nice to see it all come together
| // TODO: handle DERPMap too! | ||
| DerpMapUpdateFrequency:time.Hour, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this needed for this PR or is it addressed in one of the PRs after this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Addressed in some upstack PRs. As of this PR we still use the old DERPMap dedicated websocket, but I'm in the process of switching everything over after this one.
6ef3db5 toa3721bbComparespikecurtis commentedJan 22, 2024
Merge activity
|
Uh oh!
There was an error while loading.Please reload this page.
This one is huge, and I'm sorry.
The problem is that once I change
tailnet.Connto start doing v2 behavior, I kind of have to change it everywhere, including in CoderSDK (CLI), the agent, wsproxy, and ServerTailnet.There is still a bit more cleanup to do, and I need to add code so that when we lose connection to the Coordinator, we mark all peers as LOST, but that will be in a separate PR since this is big enough!