- Notifications
You must be signed in to change notification settings - Fork913
feat: add tailnet v2 support to wsproxy coordinate endpoint#11637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJan 16, 2024
ContributorAuthor
spikecurtis commentedJan 16, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This was referencedJan 16, 2024
3a10b53
to83ae54d
Compare4177202
to04e3985
Compare83ae54d
to175ebed
Compare04e3985
to64caaac
Comparecoadler approved these changesJan 17, 2024
175ebed
to9ee69e8
Compare64caaac
to2bced78
Compare9ee69e8
to3cb5874
Compare2bced78
toafd20a0
Compare3cb5874
to173bcc1
Compare Base automatically changed fromspike/10533-setBlockEndpoints-nodeupdater tomainJanuary 18, 2024 06:02
afd20a0
to0b9455c
CompareContributorAuthor
spikecurtis commentedJan 18, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
wsproxy also needs to be updated to use tailnet v2 because the
tailnet.Conn
stores peers by ID, and the peerID was not being carried by the JSON protocol. This adds a query param to the endpoint to conditionally switch to the new protocol.