Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: enable oauth2 token exchange#11609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedJan 13, 2024•
edited
Loading

Closes#11084

Stacked manually so I can compare the experience to Graphite. Depends on:

TODO

  • /authorize static page
  • /authorize redirect
  • /tokens GET
  • /tokens DELETE (revoke)
  • Add endpoints for discoverability
  • Refresh auth grant flow
    • Disable auto-refresh on oauth-generated API keys
  • Hash secrets
  • Handle other auth styles
  • Handle no user agent for /authorize. Return text payload with href??
  • Audit logs
    • Create app
    • Delete app
    • Edit app
    • Revoke app?
    • Authorize app?
    • Token exchange
  • Allow admin to revoke an app for a user
  • Documentation
  • Could use an upsert for replacing the code

@code-ashercode-asherforce-pushed theasher/oauth2-exchange branch 8 times, most recently from2e06e4d to4601a22CompareJanuary 16, 2024 18:52
@code-ashercode-asher marked this pull request as ready for reviewJanuary 16, 2024 20:23
Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TypeScript code looks good! Just had some suggestions/questions

@Emyrk - I'm not experienced enough in Go/SQL to give much feedback, but as long as those are good, this PR should be clear to approve

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJan 17, 2024•
edited
Loading

✔️ PR 11609 Updated successfully.
🚀 Access the credentialshere.

cc:@code-asher

github-actions[bot] reacted with rocket emoji

@code-ashercode-asher marked this pull request as draftJanuary 19, 2024 23:29
@code-ashercode-asher changed the base branch frommain toasher/oauth2-exchange-feJanuary 20, 2024 05:02
@code-ashercode-asherforce-pushed theasher/oauth2-exchange-fe branch 2 times, most recently from0514f83 to8dbae57CompareJanuary 23, 2024 18:56
@code-ashercode-asher changed the titlefeat: add oauth2 token exchangefeat: enable oauth2 token exchangeJan 23, 2024
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelFeb 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@EmyrkEmyrkEmyrk left review comments

@ParkreinerParkreinerParkreiner left review comments

Assignees

@code-ashercode-asher

Labels
staleThis issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Coder to be an OAuth provider
3 participants
@code-asher@Emyrk@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp