Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: cancel concurrent builds with native feature#116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jawnsy merged 1 commit intomainfromjawnsy/cancel-concurrent-workflows
Feb 1, 2022

Conversation

jawnsy
Copy link

Use the native 'concurrency' configuration feature to cancel
concurrent builds, rather than the cancel-workflow-action.
This also allows us to reduce permissions for the workflow.

Use the native 'concurrency' configuration feature to cancelconcurrent builds, rather than the cancel-workflow-action.This also allows us to reduce permissions for the workflow.
@jawnsyjawnsy self-assigned thisFeb 1, 2022
@codecov
Copy link

codecovbot commentedFeb 1, 2022
edited
Loading

Codecov Report

Merging#116 (f77eeda) intomain (7cf686c) willincrease coverage by3.00%.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff             @@##             main     #116      +/-   ##==========================================+ Coverage   68.92%   71.93%   +3.00%==========================================  Files          86       91       +5       Lines        3447     3670     +223       Branches       59       59              ==========================================+ Hits         2376     2640     +264+ Misses        883      813      -70- Partials      188      217      +29
FlagCoverage Δ
unittest-go-macos-latest68.13% <ø> (+0.31%)⬆️
unittest-go-ubuntu-latest69.80% <ø> (?)
unittest-go-windows-latest67.38% <ø> (?)
unittest-js74.72% <ø> (ø)
Impacted FilesCoverage Δ
coderd/userpassword/userpassword.go63.41% <0.00%> (ø)
provisioner/terraform/parse.go75.00% <0.00%> (ø)
provisioner/terraform/provision.go57.62% <0.00%> (ø)
database/postgres/postgres.go70.00% <0.00%> (ø)
provisioner/terraform/serve.go66.66% <0.00%> (ø)
peer/channel.go87.19% <0.00%> (+2.43%)⬆️
peer/conn.go79.68% <0.00%> (+3.90%)⬆️
coderd/coderdtest/coderdtest.go100.00% <0.00%> (+22.64%)⬆️
database/migrate.go52.38% <0.00%> (+52.38%)⬆️
database/pubsub.go77.08% <0.00%> (+77.08%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update7cf686c...f77eeda. Read thecomment docs.

@jawnsyjawnsy marked this pull request as ready for reviewFebruary 1, 2022 00:11
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Neato!


# Cancel in-progress runs for pull requests when developers push
# additional changes
concurrency:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@jawnsyjawnsy merged commit515e55d intomainFeb 1, 2022
@jawnsyjawnsy deleted the jawnsy/cancel-concurrent-workflows branchFebruary 1, 2022 00:13
@jawnsyjawnsy removed their assignmentMar 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@bryphe-coderbryphe-coderAwaiting requested review from bryphe-coder

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jawnsy@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp