Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: batch workspace updates#11583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 14 commits intomainfrombatch-update
Jan 18, 2024
Merged

feat: batch workspace updates#11583

aslilac merged 14 commits intomainfrombatch-update
Jan 18, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedJan 11, 2024•
edited
Loading

Closes#11326

  • Will show a warning about updating workspaces while they're in use if any selected workspaces are running.
  • Will show a warning for any selected dormant workspaces, and ignore them.
  • Shows a summary of the updated templates, their latest update messages, and which workspaces use which template.
  • Skips selected workspaces which are already up-to-date
Screen.Recording.2024-01-16.at.4.52.31.PM.mov

@matifali
Copy link
Member

Are you checking if a workspace is already on the latest version? We should start it again in such cases.

@aslilac
Copy link
MemberAuthor

Are you checking if a workspace is already on the latest version? We should start it again in such cases.

it now checks if they're already on the latest version, but it seems like the consensus is to leave up-to-date workspaces untouched (including stopped ones)

matifali reacted with thumbs up emoji

@aslilacaslilac marked this pull request as ready for reviewJanuary 17, 2024 00:10
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code looks good. I'm wondering if we should add integration tests for all 4 scenarios you described in the PR description.

Parkreiner and aslilac reacted with thumbs up emoji
Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, this also looks good to me, too. Just had one question about a change that could make the code easier to maintain down the line, but that I don't have enough context to say is a good change or not

@aslilac
Copy link
MemberAuthor

just need to get storybook working and this'll be ready. but the component usesuseQuery 💀

@aslilacaslilac merged commit9ed3487 intomainJan 18, 2024
@aslilacaslilac deleted the batch-update branchJanuary 18, 2024 22:14
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@ParkreinerParkreinerParkreiner approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Bulk workspace update for the Operator
4 participants
@aslilac@matifali@BrunoQuaresma@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp