NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

fix(site): improve rendering of provisioner tags#11575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

johnstcn merged 4 commits intomainfromcj/ui-provisionerd-tags

Jan 11, 2024

Merged

fix(site): improve rendering of provisioner tags#11575

johnstcn merged 4 commits intomainfromcj/ui-provisionerd-tags

Jan 11, 2024

Conversation

Copy link

Member

johnstcn commentedJan 11, 2024

Attempt at fixing#11542

For tags with boolean values (["true", "1", "yes", "false", "0", "no", ""]), renders asBooleanPill.
Otherwise, renders a Pill withkey: value.

fix(site): improve rendering of provisioner tags

33cb286

johnstcn requested a review fromBrunoQuaresma

January 11, 2024 13:55

johnstcn self-assigned this

Jan 11, 2024

Copy link

Member

matifali commentedJan 11, 2024

I think this serves the purpose. 🌮 cool design. 👍🏼

fixup! fix(site): improve rendering of provisioner tags

bbc634d

Copy link

Contributor

f0ssel commentedJan 11, 2024•
edited
Loading

I'm also looking into rendering tags in#11360 and I find the boolean tags to be a little confusing at first glance. It may be that I prefer verbosity, but I think I would rather have the boolean values displayed the same as the key value pairs. So something like( *checkmark* tag_true: true ) and( *checkmark* tag_1: 1 ) so you know the exact values if you want to run a new provisioner. Otherwise I like the design and use of logos and color.