NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

fix(site): show wsproxy errors in context in WorkspaceProxyPage#11556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

johnstcn merged 3 commits intomainfromcj/workspaceproxy-health-errors

Jan 11, 2024

Merged

fix(site): show wsproxy errors in context in WorkspaceProxyPage#11556

johnstcn merged 3 commits intomainfromcj/workspaceproxy-health-errors

Jan 11, 2024

Conversation

Copy link

Member

johnstcn commentedJan 10, 2024•
edited
Loading

Shows the overall report error at the top of the page, if present.
Shows workspaceproxy errors above warnings inside the corresponding element, if present.

johnstcn requested a review fromBrunoQuaresma

January 10, 2024 17:36

johnstcn self-assigned this

Jan 10, 2024

johnstcn changed the title~~fix(site): WorkspaceProxyPage: show wsproxy errors in context~~fix(site): show wsproxy errors in context in WorkspaceProxyPage

Jan 10, 2024

johnstcn commented

Jan 10, 2024

View reviewed changes

site/src/pages/HealthPage/WorkspaceProxyPage.tsx Outdated

Comment on lines 149 to 151

		{errors.map((error, i) => (
		<span key={i}>{error}</span>
		))}
		{warnings.map((warning, i) => (
		<span key={i}>{warning}</span>
		))}

Copy link

MemberAuthor

johnstcnJan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I tried turning this into an<ul> and playing around withlist-style-type to prefix these with 🚫 or⚠️ respectively, but this didn't seem to do what I wanted.