- Notifications
You must be signed in to change notification settings - Fork1k
feat: load variables from tfvars files#11549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| varsFiles,err=DiscoverVarsFiles(uploadFlags.directory) | ||
| iferr!=nil { | ||
| returnerr | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I could imagine a case where someone had tfvars files lying around unused before, worked around the issue, and left them there. Now we're going to auto-discover them. I'm not sure what this will break.
Should at the very least add an info message about the auto-discovered vars files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, I changed the code to print a message alerting about the presence of tfvars 👍
Uh oh!
There was an error while loading.Please reload this page.
| stringData[attribute.Name]=ctyValue.AsString() | ||
| }elseifctyType.Equals(cty.Number) { | ||
| stringData[attribute.Name]=ctyValue.AsBigFloat().String() | ||
| }elseifctyType.IsTupleType() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I immediately saw this, thought 🤔 "y no switch", and then saw how annoying this is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, unfortunately the API isn't too friendly :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, some comments.
Uh oh!
There was an error while loading.Please reload this page.
Fixes:#8501
This PR expands the
template pushandtemplate createto review.tfvarsand.tfvars.jsonfiles while uploading next template version. CLI will support a flat variable structure:HCL
JSON
{"region":"us-east-1","cores":2,"go_image": ["1.19","1.20","1.21"]}TODO: