Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ci: build a multi-arch image on each commit tomain#11544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 30 commits intomainfrommulti-arch-main
Jan 18, 2024
Merged

Conversation

matifali
Copy link
Member

@matifalimatifali commentedJan 10, 2024•
edited
Loading

  1. builds a multi-arch image
  2. adds a new tagghcr.io/coder/coder-preview:latest
  3. closesci: do not skip build check in PRs #11127

builds a multi-arch image andcloses#11127
@matifalimatifali changed the titleci: builds a multi-archmain imageci: build a multi-archmain imageJan 10, 2024
@matifalimatifali marked this pull request as ready for reviewJanuary 10, 2024 22:52
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can the changes to build be made a separate PR?

@matifali
Copy link
MemberAuthor

@johnstcn The PR is mainly about changing build to build, push, and multi-arch image. I sneaked in the fix to build on the PR branch as an additional fix, as it is related.

@matifalimatifali changed the titleci: build a multi-archmain imageci: build a multi-arch image on each commit tomain with taglatestJan 11, 2024
@matifali
Copy link
MemberAuthor

@deansheather@johnstcn thoughts on renaming tag from something like:main-2.6.0-devel-7b30f2849 to:v2.6.0-devel-7b30f2849 only?

The issue is that currently when we run

make -j build/coder_"$version"_linux_{amd64,arm64,armv7}.tag

This creates images with tags:v2.6.0-devel-7b30f2849-{amd64,arm64,armv7}, which are needed to create the multi-arch manifest. So we can name our multi-arch manifest tagv2.6.0-devel-7b30f2849 instead of:main-2.6.0-devel-7b30f2849

With this chnage, we will not have a mix of:main-2.6.0-devel-7b30f2849 and:v2.6.0-devel-7b30f2849-{amd64,arm64,armv7} tags.

Please look at the screenshot for the tags' name notation mixing. We can also update Makefile to allow the creation of custom tags for arch images so that they have 'main' appended to their name.

image

@matifalimatifali changed the titleci: build a multi-arch image on each commit tomain with taglatestci: build a multi-arch image on each commit tomainJan 17, 2024
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work! Approved pending Dean's outstanding items.

@matifalimatifalienabled auto-merge (squash)January 18, 2024 10:50
@matifalimatifali merged commit1ea70ba intomainJan 18, 2024
@matifalimatifali deleted the multi-arch-main branchJanuary 18, 2024 10:57
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@matifalimatifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: do not skip build check in PRs
3 participants
@matifali@johnstcn@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp