NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

chore: instrument github oauth2 limits#11532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Emyrk merged 5 commits intomainfromstevenmasley/github_ratelimit

Jan 10, 2024

Merged

chore: instrument github oauth2 limits#11532

Emyrk merged 5 commits intomainfromstevenmasley/github_ratelimit

Jan 10, 2024

Conversation

Copy link

Member

Emyrk commentedJan 9, 2024•
edited
Loading

What this does

The other PR tracks outbound requests, but github tells us our rate limits in all responses. This pr adds some additional rate limit metrics for github.

This should be even more helpful identifying how close we get to our limits.

Example prom metrics

Example

# HELP coderd_oauth2_external_requests_rate_limit_next_reset_unix Unix timestamp of the next interval# TYPE coderd_oauth2_external_requests_rate_limit_next_reset_unix gaugecoderd_oauth2_external_requests_rate_limit_next_reset_unix{name="primary-github",resource="core"} 1.704835507e+09coderd_oauth2_external_requests_rate_limit_next_reset_unix{name="secondary-github",resource="core"} 1.704835507e+09coderd_oauth2_external_requests_rate_limit_next_reset_unix{name="secondary-github",resource="core-unauthorized"} 1.70483538e+09# HELP coderd_oauth2_external_requests_rate_limit_remaining The remaining number of allowed requests in this interval.# TYPE coderd_oauth2_external_requests_rate_limit_remaining gaugecoderd_oauth2_external_requests_rate_limit_remaining{name="primary-github",resource="core"} 4894coderd_oauth2_external_requests_rate_limit_remaining{name="secondary-github",resource="core"} 4890coderd_oauth2_external_requests_rate_limit_remaining{name="secondary-github",resource="core-unauthorized"} 0# HELP coderd_oauth2_external_requests_rate_limit_reset_in_seconds Seconds until the next interval# TYPE coderd_oauth2_external_requests_rate_limit_reset_in_seconds gaugecoderd_oauth2_external_requests_rate_limit_reset_in_seconds{name="primary-github",resource="core"} 193.928881099coderd_oauth2_external_requests_rate_limit_reset_in_seconds{name="secondary-github",resource="core"} 192.443556963coderd_oauth2_external_requests_rate_limit_reset_in_seconds{name="secondary-github",resource="core-unauthorized"} 70.670050739# HELP coderd_oauth2_external_requests_rate_limit_total The total number of allowed requests per interval.# TYPE coderd_oauth2_external_requests_rate_limit_total gaugecoderd_oauth2_external_requests_rate_limit_total{name="primary-github",resource="core"} 5000coderd_oauth2_external_requests_rate_limit_total{name="secondary-github",resource="core"} 5000coderd_oauth2_external_requests_rate_limit_total{name="secondary-github",resource="core-unauthorized"} 60# HELP coderd_oauth2_external_requests_rate_limit_used The number of requests made in this interval.# TYPE coderd_oauth2_external_requests_rate_limit_used gaugecoderd_oauth2_external_requests_rate_limit_used{name="primary-github",resource="core"} 106coderd_oauth2_external_requests_rate_limit_used{name="secondary-github",resource="core"} 110coderd_oauth2_external_requests_rate_limit_used{name="secondary-github",resource="core-unauthorized"} 108