Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: display application name over sign in form#11500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
f0ssel merged 1 commit intomainfromf0ssel/sign-in-name
Jan 9, 2024

Conversation

f0ssel
Copy link
Contributor

Closes#11345

Before:
Screenshot 2024-01-08 at 12 50 54 PM

After:
Screenshot 2024-01-08 at 12 51 08 PM
Screenshot 2024-01-08 at 1 02 17 PM

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not very comfortable with this change but maybe I'm nitpicking a bit. I never saw any other platform having the company name only on the sign-in page but if you feel we should do that we can give it a try.

@f0ssel
Copy link
ContributorAuthor

I gave the customer the benefit of the doubt because we have the "Sign In" button at the end of the form. I'm not married to this solution and think we can iterate. My goal is to make the Application Name feature function the way customers expect it to - by displaying it in some way on the login screen. Thanks for the feedback and feel free to suggest future changes.

@f0sself0ssel merged commit4fa0712 intomainJan 9, 2024
@f0sself0ssel deleted the f0ssel/sign-in-name branchJanuary 9, 2024 17:51
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 9, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@f0sself0ssel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Logo URL in Appearance dashboard does not explain that it also updates the logo on the Sign In page

2 participants

@f0ssel@BrunoQuaresma

[8]ページ先頭

©2009-2025 Movatter.jp