Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): add healthcheck page for provisioner daemons#11494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 4 commits intomainfromcj/provisionerd-healthcheck-ui
Jan 8, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedJan 8, 2024•
edited
Loading

Part of#10676

  • Adds a health section for provisioner daemons (mostly cannibalized from the Workspace Proxy section)
  • Adds a corresponding storybook entry for provisioner daemons health section
  • Fixed an issue where dismissing the provisioner daemons warnings would result in a 500 error
  • Adds provisioner daemon error codes to docs

Storybook screenshot:

image

import{ProvisionerDaemonsPage}from"./ProvisionerDaemonsPage";
import{generateMeta}from"./storybook";

constmeta:Meta={
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should we also add other stories to cover different conditions of this UI view?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, we need to do this for essentially all of the provisionerd healthchecks. I think this can be resolved in#10785

@mtojek
Copy link
Member

Also, you may want to place the UI screenshot in the PR description :)

johnstcn and BrunoQuaresma reacted with thumbs up emoji

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks very good! Great work on FE@johnstcn 🙏

johnstcn reacted with heart emoji
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@johnstcnjohnstcn merged commit220e95d intomainJan 8, 2024
@johnstcnjohnstcn deleted the cj/provisionerd-healthcheck-ui branchJanuary 8, 2024 17:14
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 8, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@mtojekmtojekmtojek approved these changes

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnstcn@mtojek@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp