- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: add support for peer updates to tailnet.configMaps#11487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
spikecurtis commentedJan 8, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
032d52d tob03a760Compared744013 to76ec6f7Compareb03a760 to6f37b9bCompare76ec6f7 to2baf90fCompare2baf90f to3844f8aCompare6f37b9b to0ec3722Compare3844f8a toe01bbcfCompared013264 to018e3b8Comparee01bbcf toa02de8bCompare40c72c2 to3b8d264Compare| varlastHandshake time.Time | ||
| ifps,ok:=status.Peer[node.Key];ok { | ||
| lastHandshake=ps.LastHandshake | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there a situation a peer would be missing from theconfigMaps peer list but still be in the engine's peer list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, immediately after receiving a DISCONNECTED update, we remove it from configMaps. Then until the next update it'll be in the engine but not configMaps. Probably an edge case for us to DISCONNECT and then immediately get a new NODE update, though.
tailnet/configmaps_internal_test.go Outdated
| // Then: we don't configure | ||
| requireNeverConfigures(ctx,t,uut) | ||
| p1ID:=uuid.MustParse("10000000-0000-0000-0000-000000000000") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A nice shorthand for this isuuid.UUID{1}
3b8d264 tob573a10Comparespikecurtis commentedJan 11, 2024
Merge activity
|
Adds support to configMaps to handle peer updates including lost and disconnected peers