- Notifications
You must be signed in to change notification settings - Fork925
chore(dogfood): update dogfood template to use artifactory#11452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dogfood/main.tf Outdated
| keep_locally = true | ||
| name = "${local.jfrog_host}/docker/${local.registry_name}:latest" | ||
| pull_triggers = [null_resource.update_trigger.id] | ||
| keep_locally = true | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This was not working nicely with a private docker registry, so I had to resort to this hack,
I filed an issue with the docker provider.
kreuzwerker/terraform-provider-docker#593
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is also not working, and terraform is not pulling the latest image even though Artifactory has it.
There are open issues regarding this:kreuzwerker/terraform-provider-docker#172
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We can skip pulling from the satisfactory in Terraform or use a new tag on each build. Probably short git sha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
After talking to@Emyrk, we decided not to use Artifactory to fetch pull docker image.
Uh oh!
There was an error while loading.Please reload this page.
This pull request updates the dogfood template to configure
npm,pip,goanddockerto fetch packages from the Artifactory. This also installs the JFrog extension in code-server.