Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: Add Contributors section to readme#1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 4 commits intomainfrommafredri/contributors
Apr 27, 2022
Merged

Conversation

mafredri
Copy link
Member

This PR adds a Contributors-section to the readme as described in#1112. Additionally the date format was explicitly documented.

Subtasks (as part of my onboarding)

  • Add Contributors-section to readme
  • Add myself as contributor

Fixes#1112

johnstcn reacted with hooray emoji
@codecov
Copy link

codecovbot commentedApr 25, 2022
edited
Loading

Codecov Report

Merging#1144 (81a9b13) intomain (a769e86) willdecrease coverage by0.26%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1144      +/-   ##==========================================- Coverage   66.26%   65.99%   -0.27%==========================================  Files         265      261       -4       Lines       16682    16482     -200       Branches      157      157              ==========================================- Hits        11054    10877     -177+ Misses       4483     4470      -13+ Partials     1145     1135      -10
FlagCoverage Δ
unittest-go-macos-latest53.46% <ø> (-0.21%)⬇️
unittest-go-postgres-65.53% <ø> (-0.09%)⬇️
unittest-go-ubuntu-latest56.15% <ø> (-0.02%)⬇️
unittest-go-windows-2022?
unittest-js66.50% <ø> (ø)
Impacted FilesCoverage Δ
peerbroker/listen.go84.03% <0.00%> (-6.73%)⬇️
cli/configssh.go61.19% <0.00%> (-6.72%)⬇️
coderd/httpapi/httpapi.go66.25% <0.00%> (-6.25%)⬇️
pty/ptytest/ptytest.go86.95% <0.00%> (-4.35%)⬇️
cli/templateinit.go58.62% <0.00%> (-3.45%)⬇️
agent/agent.go63.12% <0.00%> (-3.20%)⬇️
coderd/workspaceagents.go55.59% <0.00%> (-2.56%)⬇️
peer/conn.go79.94% <0.00%> (-1.27%)⬇️
peer/channel.go83.23% <0.00%> (-0.58%)⬇️
coderd/provisionerdaemons.go62.79% <0.00%> (-0.51%)⬇️
... and7 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatea769e86...81a9b13. Read thecomment docs.

@kylecarbs
Copy link
Member

I wonder if this could be autogenned? I've seen that on other repos before, but I'm having trouble finding them!

@mafredri
Copy link
MemberAuthor

@kylecarbs I like that idea! I've seen things likeactions/contributors-list which displays the users picture/name.

Are we ok with utilizing GitHub Actions for this? And do we want to include the extended information likefirst PR date andorganization? The former may be queryable via GitHub API (need to verify), but as for the latter the user could be part of multiple organizations.

Co-authored-by: Cian Johnston <public@cianjohnston.ie>
@mafredrimafredrienabled auto-merge (squash)April 27, 2022 11:43
@mafredrimafredri merged commit0b1ee33 intomainApr 27, 2022
@mafredrimafredri deleted the mafredri/contributors branchApril 27, 2022 11:48
@kylecarbs
Copy link
Member

@mafredri I was thinking we'd use something like:https://contrib.rocks/preview?repo=coder%2Fcode-server

@mafredri
Copy link
MemberAuthor

Ah, that's actually a pretty nice solution to avoid having to re-generate the README. I suppose we would need a self-hosted solution to access the private repo? One downside with the image version is that you can't click to the users profile (if we consider that important).

@kylecarbs
Copy link
Member

That's true. I'd be in favor of usingcontributors-list in that case, I'm concerned that the manually maintained list will not be manually maintained 😁

@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Co-authored-by: Cian Johnston <public@cianjohnston.ie>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Create Contributors section in README.md
4 participants
@mafredri@kylecarbs@johnstcn@misskniss

[8]ページ先頭

©2009-2025 Movatter.jp