Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: select group avatars with the emoji picker#11395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 6 commits intomainfromuser-group-icon-picker
Jan 3, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedJan 3, 2024
edited
Loading

Closes#11365

  • Use theIconField component instead of a plainTextField on the new group page
  • RefactorIconField to be lazy by default
  • RemoveLazyIconField
  • Move the lazy boundary to make the loading invisible to users (this makes a multiple second difference in page loads!!)

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great improvement!

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@aslilac 🙏

@aslilacaslilac merged commitffa7722 intomainJan 3, 2024
@aslilacaslilac deleted the user-group-icon-picker branchJanuary 3, 2024 22:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@matifalimatifalimatifali approved these changes

Assignees

@aslilacaslilac

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Groups: Add emoji/icon picker to group avatar

3 participants

@aslilac@BrunoQuaresma@matifali

[8]ページ先頭

©2009-2025 Movatter.jp