- Notifications
You must be signed in to change notification settings - Fork1k
fix(coderd/database): add missing v prefix to provisioner_daemons.api_version#11385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
a5e4f8c to4bab3e8Compareaab20f2 tobe3bc7bComparemafredri approved these changesJan 3, 2024
| // Breaking changes to the provisionerd API **MUST** increment | ||
| // the major version below. | ||
| APIVersionCurrent="1.0" | ||
| APIVersionCurrent="v1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If this is semver, should it be v1.0.0? Maybe this shorthand is allowed though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
// The general form of a semantic version string accepted by this package is////vMAJOR[.MINOR[.PATCH[-PRERELEASE][+BUILD]]]//// where square brackets indicate optional parts of the syntax;So shorthand is OK here.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding
provisioner_daemons.api_versioninitially I missed thevprefix.This is a requirement of
/x/mod/semver, so adding a small migration to normalize this now.