Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor(site): simplify workspace topbar#11370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 4 commits intomainfrombq/refactor-new-ws-header
Jan 2, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

From@mafredri feedback:

  • It looks a bit busy in my eyes, I think it could be simplified further.
  • Maybe we can change the beginning to [template icon] [username] / [workspace] (i) [Stops in ...]. My thought is that behind (i) (info) we can show template name, current version, etc.
  • the current version of the workspace/template is quite uninteresting and only needed in special circumstances.

Changes:

  • Moved template name and version into a tooltip when hovering the template icon
  • Moved the user name to be the first info in the "workspace path"
  • Removed the outdated pill as well since we already have on the page an update button and alert with this information.

Before:
Screenshot 2024-01-02 at 14 24 34

After:
Screenshot 2024-01-02 at 14 50 34

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Love it, great work! ❤️

mode="hover"
// title={`${
// workspace.template_display_name ?? workspace.template_name
// } on version ${workspace.latest_build.template_version_name}`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is the commented code intentional? Will it be used later?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No, ty!

@BrunoQuaresmaBrunoQuaresma merged commitc37c0e7 intomainJan 2, 2024
@BrunoQuaresmaBrunoQuaresma deleted the bq/refactor-new-ws-header branchJanuary 2, 2024 18:17
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 2, 2024
@BrunoQuaresma
Copy link
CollaboratorAuthor

Related to#11491

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredrimafredri approved these changes

@matifalimatifalimatifali approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrunoQuaresma@mafredri@matifali

[8]ページ先頭

©2009-2025 Movatter.jp