- Notifications
You must be signed in to change notification settings - Fork923
chore: disable failing metrics check until it can be fixed#11361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Current dependencies on/for this PR: Thisstack of pull requests is managed byGraphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is a hotfix and has been automatically approved.
- ✅ Base is main
- ✅ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
4d79c45 tof3d8f02Compare@spikecurtis I see both SSH and RPTY were disabled here, do you have a link to a failure for the SSH test? AFAIK only RPTY was linked in the issue. |
Might have been overzealous; I assumed they were both affected by the underlying |
Nope, only for RPTY and only when No need to re-enable it for now though, I can do that at a later time when I make some other changes. Was just interested in seeing the failure if there was any. 👍🏻 |
#11175 is causing CI failures nearly every time. We are still debating the correct fix for it; in the mean time, I'm disabling the metrics check that is failing so that we don't block unrelated merges.