Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add optional coder_app to faq#11351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
stirby merged 5 commits intomainfromdocs-faq-optional-coder-app
Jan 11, 2024
Merged

Conversation

sharkymark
Copy link
Contributor

This is PR:

Adds an FAQ entry showing how to make acoder_app resource optional and dependent on acoder_parameter

The use case is letting a user decide if they want acode-server browser IDE or not in a workspace.

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few suggestions.

docs/faqs.md Outdated
Comment on lines 417 to 418
name = "code-server (optional)"
description = "Use VS Code in a browser"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
name = "code-server(optional)"
description = "Use VS Code in a browser"
name = "Do you wantcode-serverin your workspace?"
description = "Use VS Code in a browser."

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJan 10, 2024
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJan 11, 2024•
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@stirby
Copy link
Collaborator

I have read the CLA Document and I hereby sign the CLA

Copy link
Collaborator

@stirbystirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

resolved atif's comments

@stirbystirby merged commitc91b885 intomainJan 11, 2024
@stirbystirby deleted the docs-faq-optional-coder-app branchJanuary 11, 2024 18:07
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@matifalimatifalimatifali approved these changes

@stirbystirbystirby approved these changes

Assignees

@sharkymarksharkymark

Labels

staleThis issue is like stale bread.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sharkymark@stirby@matifali
[8]ページ先頭
©2009-2025 Movatter.jp