Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: remove tailnet from agent API and rename client API to tailnet#11303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/agent-tailnet-rpc-rename
Jan 2, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedDec 21, 2023
edited
Loading

Refactors our DRPC service definitions slightly.

In the previous version, I inserted the RPCs from the tailnet proto directly into the Agent service. This makes things hard to deal with because DRPC then generates a new set of methods with new interfaces with theDRPCAgent_ prefixed. Since you can't have a single method that takes different argument types, we couldn't reuse the implementation of those RFCs without a lot of extra classes and pass-thru methods.

Instead, the "right" way to do it is to integrate at the DRPC layer. So, we have two DRPC services available over the Agent websocket, and register them both on the DRPCmux.

Since the tailnet proto RPC service is now for both clients and agents, I renamed some things to clarify and shorten.

This PR also removes theTailnetAPI implementation from theagentapi package, and the next PR in the stack replaces it with the implementation from thetailnet package.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedDec 21, 2023
edited
Loading

Base automatically changed fromspike/10532-derp-streaming tomainJanuary 2, 2024 04:07
@spikecurtisspikecurtisforce-pushed thespike/agent-tailnet-rpc-rename branch from29e4a7f to722ef25CompareJanuary 2, 2024 04:09
@spikecurtisspikecurtisforce-pushed thespike/agent-tailnet-rpc-rename branch from722ef25 tofccb3b8CompareJanuary 2, 2024 05:50
@spikecurtisspikecurtis merged commit25f2abf intomainJan 2, 2024
@spikecurtisspikecurtis deleted the spike/agent-tailnet-rpc-rename branchJanuary 2, 2024 06:02
@spikecurtisGraphite App
Copy link
ContributorAuthor

Merge activity

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 2, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@spikecurtisspikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spikecurtis@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp