NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

Revert "chore: bump @material-ui/core from 4.9.4 to 4.12.3"#113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kylecarbs merged 1 commit intomainfromrevert-102-dependabot/npm_and_yarn/material-ui/core-4.12.3

Jan 31, 2022

Merged

Revert "chore: bump @material-ui/core from 4.9.4 to 4.12.3"#113

kylecarbs merged 1 commit intomainfromrevert-102-dependabot/npm_and_yarn/material-ui/core-4.12.3

Jan 31, 2022

Conversation

Copy link

Member

kylecarbs commentedJan 31, 2022•
edited
Loading

Reverts#102

This broke the types on main.test/js wasn't a required check before, so it allowed this dependency to be merged. That's been fixed!

Revert "chore: bump @material-ui/core from 4.9.4 to 4.12.3 (#102)"

fa899f6

This reverts commitd65ce2d.

kylecarbs self-assigned this

Jan 31, 2022

kylecarbs requested a review frombryphe-coder

January 31, 2022 14:13

Copy link

codecovbot commentedJan 31, 2022•
edited
Loading

Codecov Report

Merging#113 (fa899f6) intomain (0f30d85) willincrease coverage by0.84%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main     #113      +/-   ##==========================================+ Coverage   71.28%   72.12%   +0.84%==========================================  Files          38       89      +51       Lines        3120     3627     +507       Branches        0       55      +55     ==========================================+ Hits         2224     2616     +392- Misses        691      791     +100- Partials      205      220      +15

Flag	Coverage Δ
unittest-go-macos-latest	`67.75% <ø> (-0.07%)`	⬇️
unittest-go-ubuntu-latest	`69.80% <ø> (-0.29%)`	⬇️
unittest-go-windows-latest	`67.79% <ø> (-0.04%)`	⬇️
unittest-js	`78.30% <ø> (?)`

Impacted Files	Coverage Δ
peer/conn.go	`77.08% <0.00%> (-2.35%)`	⬇️
site/components/Navbar/UserDropdown.tsx	`88.00% <0.00%> (ø)`
site/components/Table/index.tsx	`0.00% <0.00%> (ø)`
site/components/Form/FormDropdownField.tsx	`91.66% <0.00%> (ø)`
site/components/Button/SplitButton.tsx	`89.47% <0.00%> (ø)`
site/components/Table/TableTitle.tsx	`84.61% <0.00%> (ø)`
site/test_helpers/mocks.ts	`100.00% <0.00%> (ø)`
site/components/Form/index.ts	`100.00% <0.00%> (ø)`
site/components/Icons/WorkspacesIcon.tsx	`100.00% <0.00%> (ø)`
site/components/Form/FormTitle.tsx	`87.50% <0.00%> (ø)`
... and43 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update0f30d85...fa899f6. Read thecomment docs.