Dec 20, 2023 · Dec 20, 2023 · Dec 20, 2023 · Dec 20, 2023 · Dec 20, 2023 · Dec 20, 2023
diff --git a/cli/templatecreate.go b/cli/templatecreate.go
 package cli

 import (
 "context"
 "errors"
 "fmt"
 "io"
 r.InitClient(client),
 ),
 Handler: func(inv *clibase.Invocation) error {
 isTemplateSchedulingOptionsSet := failureTTL != 0 || dormancyThreshold != 0 || dormancyAutoDeletion != 0 || maxTTL != 0

 if isTemplateSchedulingOptionsSet || requireActiveVersion {
 if failureTTL != 0 || dormancyThreshold != 0 || dormancyAutoDeletion != 0 {
 // This call can be removed when workspace_actions is no longer experimental
 experiments, exErr := client.Experiments(inv.Context())
 if exErr != nil {
 return xerrors.Errorf("get experiments: %w", exErr)
 }

 if !experiments.Enabled(codersdk.ExperimentWorkspaceActions) {
 return xerrors.Errorf("--failure-ttl, --dormancy-threshold, and --dormancy-auto-deletion are experimental features. Use the workspace_actions CODER_EXPERIMENTS flag to set these configuration values.")
 }
 }

 entitlements, err := client.Entitlements(inv.Context())
 if cerr, ok := codersdk.AsError(err); ok && cerr.StatusCode() == http.StatusNotFound {
 return xerrors.Errorf("your deployment appears to be an AGPL deployment, so you cannot set enterprise-only flags")
 } else if err != nil {
 return xerrors.Errorf("get entitlements: %w", err)
 }

 if isTemplateSchedulingOptionsSet {
 if !entitlements.Features[codersdk.FeatureAdvancedTemplateScheduling].Enabled {
 return xerrors.Errorf("your license is not entitled to use advanced template scheduling, so you cannot set --failure-ttl, --inactivity-ttl, or --max-ttl")
 }
 }

 if requireActiveVersion {
 if !entitlements.Features[codersdk.FeatureAccessControl].Enabled {
 return xerrors.Errorf("your license is not entitled to use enterprise access control, so you cannot set --require-active-version")
 }
 }
 _, _ = fmt.Fprintln(inv.Stdout, "\n"+pretty.Sprint(cliui.DefaultStyles.Wrap,
 pretty.Sprint(
 cliui.DefaultStyles.Warn, "DEPRECATION WARNING: The `coder templates push` command should be used instead. This command will be removed in a future release. ")+"\n"))
 time.Sleep(1 * time.Second)

 err := checkTemplateCreateEntitlements(inv.Context(), checkTemplateCreateEntitlementsArgs{
 client:               client,
 requireActiveVersion: requireActiveVersion,
 defaultTTL:           defaultTTL,
 failureTTL:           failureTTL,
 dormancyThreshold:    dormancyThreshold,
 dormancyAutoDeletion: dormancyAutoDeletion,
 maxTTL:               maxTTL,
 })
 if err != nil {
 return err
 }

 organization, err := CurrentOrganization(inv, client)
 }
 return tags, nil
 }

 type checkTemplateCreateEntitlementsArgs struct {
 client               *codersdk.Client
 requireActiveVersion bool
 defaultTTL           time.Duration
 failureTTL           time.Duration
 dormancyThreshold    time.Duration
 dormancyAutoDeletion time.Duration
 maxTTL               time.Duration
 }

 func checkTemplateCreateEntitlements(ctx context.Context, args checkTemplateCreateEntitlementsArgs) error {
 isTemplateSchedulingOptionsSet := args.failureTTL != 0 || args.dormancyThreshold != 0 || args.dormancyAutoDeletion != 0 || args.maxTTL != 0

 if isTemplateSchedulingOptionsSet || args.requireActiveVersion {
 if args.failureTTL != 0 || args.dormancyThreshold != 0 || args.dormancyAutoDeletion != 0 {
 // This call can be removed when workspace_actions is no longer experimental
 experiments, exErr := args.client.Experiments(ctx)
 if exErr != nil {
 return xerrors.Errorf("get experiments: %w", exErr)
 }

 if !experiments.Enabled(codersdk.ExperimentWorkspaceActions) {
 return xerrors.Errorf("--failure-ttl, --dormancy-threshold, and --dormancy-auto-deletion are experimental features. Use the workspace_actions CODER_EXPERIMENTS flag to set these configuration values.")
 }
 }

 entitlements, err := args.client.Entitlements(ctx)
 if cerr, ok := codersdk.AsError(err); ok && cerr.StatusCode() == http.StatusNotFound {
 return xerrors.Errorf("your deployment appears to be an AGPL deployment, so you cannot set enterprise-only flags")
 } else if err != nil {
 return xerrors.Errorf("get entitlements: %w", err)
 }

 if isTemplateSchedulingOptionsSet {
 if !entitlements.Features[codersdk.FeatureAdvancedTemplateScheduling].Enabled {
 return xerrors.Errorf("your license is not entitled to use advanced template scheduling, so you cannot set --failure-ttl, --inactivity-ttl, or --max-ttl")
 }
 }

 if args.requireActiveVersion {
 if !entitlements.Features[codersdk.FeatureAccessControl].Enabled {
 return xerrors.Errorf("your license is not entitled to use enterprise access control, so you cannot set --require-active-version")
 }
 }
 }

 return nil
 }
Original file line number	Diff line number	Diff line change
		@@ -1,6 +1,7 @@
		package cli

		import (
		"context"
		"errors"
		"fmt"
		"io"
Expand DownExpand Up		@@ -46,39 +47,22 @@ func (r RootCmd) templateCreate() clibase.Cmd {
		r.InitClient(client),
		),
		Handler: func(inv *clibase.Invocation) error {
		isTemplateSchedulingOptionsSet := failureTTL != 0 \|\| dormancyThreshold != 0 \|\| dormancyAutoDeletion != 0 \|\| maxTTL != 0

		if isTemplateSchedulingOptionsSet \|\| requireActiveVersion {
		if failureTTL != 0 \|\| dormancyThreshold != 0 \|\| dormancyAutoDeletion != 0 {
		// This call can be removed when workspace_actions is no longer experimental
		experiments, exErr := client.Experiments(inv.Context())
		if exErr != nil {
		return xerrors.Errorf("get experiments: %w", exErr)
		}

		if !experiments.Enabled(codersdk.ExperimentWorkspaceActions) {
		return xerrors.Errorf("--failure-ttl, --dormancy-threshold, and --dormancy-auto-deletion are experimental features. Use the workspace_actions CODER_EXPERIMENTS flag to set these configuration values.")
		}
		}

		entitlements, err := client.Entitlements(inv.Context())
		if cerr, ok := codersdk.AsError(err); ok && cerr.StatusCode() == http.StatusNotFound {
		return xerrors.Errorf("your deployment appears to be an AGPL deployment, so you cannot set enterprise-only flags")
		} else if err != nil {
		return xerrors.Errorf("get entitlements: %w", err)
		}

		if isTemplateSchedulingOptionsSet {
		if !entitlements.Features[codersdk.FeatureAdvancedTemplateScheduling].Enabled {
		return xerrors.Errorf("your license is not entitled to use advanced template scheduling, so you cannot set --failure-ttl, --inactivity-ttl, or --max-ttl")
		}
		}

		if requireActiveVersion {
		if !entitlements.Features[codersdk.FeatureAccessControl].Enabled {
		return xerrors.Errorf("your license is not entitled to use enterprise access control, so you cannot set --require-active-version")
		}
		}
		_, _ = fmt.Fprintln(inv.Stdout, "\n"+pretty.Sprint(cliui.DefaultStyles.Wrap,
		pretty.Sprint(
		cliui.DefaultStyles.Warn, "DEPRECATION WARNING: The `coder templates push` command should be used instead. This command will be removed in a future release. ")+"\n"))
		time.Sleep(1 * time.Second)
Copy link Member ammarioJan 2, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Love the sleep-based incentive, but we should tell the user that it's sleeping for a moment in the deprecation message so that the user doesn't just think our CLI is slow.

		err := checkTemplateCreateEntitlements(inv.Context(), checkTemplateCreateEntitlementsArgs{
		client: client,
		requireActiveVersion: requireActiveVersion,
		defaultTTL: defaultTTL,
		failureTTL: failureTTL,
		dormancyThreshold: dormancyThreshold,
		dormancyAutoDeletion: dormancyAutoDeletion,
		maxTTL: maxTTL,
		})
		if err != nil {
		return err
		}

		organization, err := CurrentOrganization(inv, client)
Expand DownExpand Up		@@ -357,3 +341,52 @@ func ParseProvisionerTags(rawTags []string) (map[string]string, error) {
		}
		return tags, nil
		}

		type checkTemplateCreateEntitlementsArgs struct {
		client *codersdk.Client
		requireActiveVersion bool
		defaultTTL time.Duration
		failureTTL time.Duration
		dormancyThreshold time.Duration
		dormancyAutoDeletion time.Duration
		maxTTL time.Duration
		}

		func checkTemplateCreateEntitlements(ctx context.Context, args checkTemplateCreateEntitlementsArgs) error {
		isTemplateSchedulingOptionsSet := args.failureTTL != 0 \|\| args.dormancyThreshold != 0 \|\| args.dormancyAutoDeletion != 0 \|\| args.maxTTL != 0

		if isTemplateSchedulingOptionsSet \|\| args.requireActiveVersion {
		if args.failureTTL != 0 \|\| args.dormancyThreshold != 0 \|\| args.dormancyAutoDeletion != 0 {
		// This call can be removed when workspace_actions is no longer experimental
		experiments, exErr := args.client.Experiments(ctx)
		if exErr != nil {
		return xerrors.Errorf("get experiments: %w", exErr)
		}

		if !experiments.Enabled(codersdk.ExperimentWorkspaceActions) {
Copy link Member ammarioJan 2, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Aside: I've noticed us call this "WorkspaceActions" and "WorkspaceCleanup" in different places. E.g.here.@sreya can we standardize on one? Workspace Cleanup makes more sense to me.
		return xerrors.Errorf("--failure-ttl, --dormancy-threshold, and --dormancy-auto-deletion are experimental features. Use the workspace_actions CODER_EXPERIMENTS flag to set these configuration values.")
		}
		}

		entitlements, err := args.client.Entitlements(ctx)
		if cerr, ok := codersdk.AsError(err); ok && cerr.StatusCode() == http.StatusNotFound {
		return xerrors.Errorf("your deployment appears to be an AGPL deployment, so you cannot set enterprise-only flags")
		} else if err != nil {
		return xerrors.Errorf("get entitlements: %w", err)
		}

		if isTemplateSchedulingOptionsSet {
		if !entitlements.Features[codersdk.FeatureAdvancedTemplateScheduling].Enabled {
		return xerrors.Errorf("your license is not entitled to use advanced template scheduling, so you cannot set --failure-ttl, --inactivity-ttl, or --max-ttl")
		}
		}

		if args.requireActiveVersion {
		if !entitlements.Features[codersdk.FeatureAccessControl].Enabled {
		return xerrors.Errorf("your license is not entitled to use enterprise access control, so you cannot set --require-active-version")
		}
		}
		}

		return nil
		}