Do we need to specify workspace name everytime?
What if we run it from an ssh session that is already connected to the workspace?
In that case we should default the current workspace a user is connected to.
Also thought about making itcoder vscode only to make it more concise?
And probably in a follow up we can also havecoder gateway

Perhaps the above should be behind the verbose flag.

Yes I agree it should be replaced with "Opening vscode desktop in workspace w"

Do we need to specify workspace name everytime? What if we run it from an ssh session that is already connected to the workspace? In that case we should default the current workspace a user is connected to.

This version was intended only for opening from a users local machine. Opening from within the workspace on the local machine is much more complicated, although I agree would be convenient.

Opening from the workplace is a much harder problem since we can’t tell the users machine to execute a command from within the SSH session. The best we can do for now within the workspace is to print the open uri and let the user open it themselves. Or, we can print a URL to the dashboard (solves the issue of providing the token without printing it in the terminal).

If getting the same automatic open experience remotely as locally is a hard requirement. Then I’d like to discuss with@deansheather about security implications and whether or not we should do it.

Also thought about making itcoder vscode only to make it more concise? And probably in a follow up we can also havecoder gateway

I did consider it, but I’m worried we’ll overload the top level scope with too many commands if we do that. Especially if more open commands are introduced.

I did consider it, but I’m worried we’ll overload the top level scope with too many commands if we do that. Especially if more open commands are introduced.

I agree with naming.

For allowing opening from the web terminal, it's just convenient and saves user from having to install coder locally first before using this command.
I think if we can just print the URI its enough and user can click on it to launch the IDE.

VSCode itself doesn't support "local open" in an SSH session outside of the integrated terminal so I don't think we should either. You can't SSH into a server and then runcode . to open a native VSCode window locally AFAIK.

There are security issues with adding a reverse shell or support for the workspace to open URLs on the local machine without input as well. A malicious workspace could run custom commands or could abuse custom scheme handlers to coerce other apps on the local system to do malicious actions. Or it could just DoS your local machine by spamming URLs.