- Notifications
You must be signed in to change notification settings - Fork928
chore(site): update test entities#11155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
site/src/testHelpers/entities.ts Outdated
| id: "test-user-provisioner", | ||
| name: "Test User Provisioner", | ||
| provisioners: ["echo"], | ||
| tags: {"scope": "user", "owner": "12345678-abcd-1234-abcd-1234567890abcd"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I admit that I'm a fan of arrays in Go as we can enforce the stable order. This form isn't wrong, but it requires extra sorting on frontend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is a hotfix and has been automatically approved.
- ✅ Base is main
- ✅ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@mtojek brought up good points but I'm ok with Records as well.
No description provided.