Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: correct 500 -> 404#11129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 3 commits intomainfromstevenmasley/agent_404
Dec 12, 2023
Merged

chore: correct 500 -> 404#11129

Emyrk merged 3 commits intomainfromstevenmasley/agent_404
Dec 12, 2023

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedDec 11, 2023•
edited
Loading

Makes 401 errors return at 404 instead of 500

Copy link
Member

@johnstcnjohnstcn left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What problem is this addressing?
If this breaks no unit tests, that makes me suspicious that we have a gap in test coverage.

@Emyrk
Copy link
MemberAuthor

What problem is this addressing? If this breaks no unit tests, that makes me suspicious that we have a gap in test coverage.

A custom was reporting they had 500 error alerting. The 500 error was"detail":"unauthorized: rbac: forbidden". This should return as a 404 and not trigger any monitoring for 500s.

@johnstcn
Copy link
Member

What problem is this addressing? If this breaks no unit tests, that makes me suspicious that we have a gap in test coverage.

A custom was reporting they had 500 error alerting. The 500 error was"detail":"unauthorized: rbac: forbidden". This should return as a 404 and not trigger any monitoring for 500s.

Should we then add a test that an expired agent token does not trigger a 5xx? Just to avoid an accidental regression for this customer in future.

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks fine to me, but we should have a test to cover this behaviour so we don't accidentally push a regression in the future.

Emyrk reacted with thumbs up emoji
@EmyrkEmyrk merged commitdba0dfa intomainDec 12, 2023
@EmyrkEmyrk deleted the stevenmasley/agent_404 branchDecember 12, 2023 21:14
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 12, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@EmyrkEmyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Emyrk@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp