Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: fix flake in TestExecutorAutostopTemplateDisabled#11096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit intomainfromjon/fixautobuildflake
Dec 8, 2023

Conversation

sreya
Copy link
Collaborator

@sreyasreya commentedDec 8, 2023
edited
Loading

Fixes a flake where the following can happen:

  • A buildstarts at23:34:59.981 but ends at23:35:00.205
  • When calculating the deadline of 1 hour we set on the build we get00:35:00.205.
  • We pass a tick that adds 61 minutes but it's based off thecreated_at instead of thecompleted_at of the build so we get00:35:59.981 which truncates down to00:35:00 which is less than the deadline.

I've gone ahead and fixed it but we should maybe reconsider whether this test should exist inautobuild since it's really testing that the deadline is set correctly inprovisionerdserver. We can't really refactor this test withdbfake without completely obviating what it's trying to test.

fixes#10359

@sreyasreyaforce-pushed thejon/fixautobuildflake branch 2 times, most recently frome6d2173 toa555022CompareDecember 8, 2023 01:33
@sreyasreyaforce-pushed thejon/fixautobuildflake branch froma555022 to4a91d09CompareDecember 8, 2023 01:33
@sreyasreya marked this pull request as ready for reviewDecember 8, 2023 01:33
@sreyasreya requested a review fromjohnstcnDecember 8, 2023 01:33
Copy link
Member

@johnstcnjohnstcn left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice find@sreya! Yeah it made sense to test setting the deadline here at the time, but testing it in provisionerdserver is the more correct place to do so.

Edit: filed#11098 to follow up.

@johnstcnjohnstcn merged commit02696f2 intomainDec 8, 2023
@johnstcnjohnstcn deleted the jon/fixautobuildflake branchDecember 8, 2023 09:02
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 8, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@sreyasreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: TestExecutorAutostopTemplateDisabled
2 participants
@sreya@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp