- Notifications
You must be signed in to change notification settings - Fork927
feat(site): bring back dark blue#11071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -32,7 +31,7 @@ export interface LicenseBannerViewProps { | |||
| warnings: string[]; | |||
| } | |||
| export const LicenseBannerView:React.FC<LicenseBannerViewProps> = ({ | |||
| export const LicenseBannerView: FC<LicenseBannerViewProps> = ({ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you know of a way to get our linter to enforce this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
no, I wish 😪
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry for the delayed review! Pulled it down and poked around - looks great!
Uh oh!
There was an error while loading.Please reload this page.
We've had feedback that some people miss the dark blue, and this is an easier first target for adding a theme switcher than light mode, so lets bring it back!
It's currently inaccessible, because it will need#11069 for persistence and another PR to actually introduce a setting for it to the app. This PR mostly exists to make that later PR more reviewable, by keeping its diff simpler.
Notable changes:
No more importing theme/colors! Colors need to be tweakable from theme to theme, and should be a part of the theme itself
Add
theme.colorsto replace the old globally importable module, and switch everyone overDuplicate theme/dark, with minor modifications, giving us theme/darkBlue
Actually fixes a minor visual bug where our buttons and inputs haven't been using Inter 💀
Some other small things snuck in because I never have any self control about those
Don't let the big line count scare you! Most of it is from moving/duplicating files without actually changing much!