Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add group allowlist for oidc#11070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 12 commits intomainfromstevenmasley/oidc_allowed_groups
Dec 8, 2023
Merged

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedDec 6, 2023•
edited
Loading

Users not in the group allowlist cannot authenticate with Coder.

The authorized groups are never returned to the user, but I will return what groups the user is in to aid in debugging.

Closes#10705

When you have 0 groups

Screenshot from 2023-12-06 15-59-43

When you are in groups that are not authorized

Screenshot from 2023-12-06 16-17-02

@EmyrkGraphite App
Copy link
MemberAuthor

Current dependencies on/for this PR:

Thisstack of pull requests is managed byGraphite.

@EmyrkEmyrkforce-pushed thestevenmasley/oidc_allowed_groups branch frome47e6c8 to524acedCompareDecember 6, 2023 19:02
@EmyrkEmyrk requested a review fromjohnstcnDecember 6, 2023 22:22
@EmyrkEmyrk marked this pull request as ready for reviewDecember 7, 2023 14:31
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This'll be handy for folks doing OIDC on a gmail domain for sure

Emyrk reacted with thumbs up emoji
@EmyrkEmyrk merged commit78517ca intomainDec 8, 2023
@EmyrkEmyrk deleted the stevenmasley/oidc_allowed_groups branchDecember 8, 2023 16:14
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 8, 2023
@matifali
Copy link
Member

matifali commentedDec 8, 2023•
edited
Loading

@Emyrk It would be nice to add some basic docshere on how to configure it in a follow up PR.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AddCODER_OIDC_ALLOWED_GROUPS to limit which groups can sign in to Coder
3 participants
@Emyrk@matifali@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp