- Notifications
You must be signed in to change notification settings - Fork923
fix: use unique workspace owners over unique users#11044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 The original value is still there too if you want to pull the total ever. Reading the issue ticket, this all makes sense.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Yeah I have a feeling people will want to know the total unique users that have ever used the templatesomewhere in the UI so I wanted to leave it for now. |
Uh oh!
There was an error while loading.Please reload this page.
Closes#10820
Currently the
active_user_counton each template is not really "active users" but the count of any user that has made a workspace that was healthy based on the template.This changes it to use the count of unique workspace owners based off the template, which I believe is what users will expect the number to be based on the issue made for this.