- Notifications
You must be signed in to change notification settings - Fork1k
fix(codersdk): make codersdk.ProvisionerDaemon.UpdatedAt a codersdk.NullTime#11037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Go for it!
Uh oh!
There was an error while loading.Please reload this page.
| |`provisioners`| array of string| false||| | ||
| |`tags`| object| false||| | ||
| | »`[any property]`| string| false||| | ||
| |`updated_at`|string| false||| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems I was wrong, stillstring. Maybe we need to look at improving the docs gen for this type. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe let's leave docs for further improvement and fix API code first 👍
Uh oh!
There was an error while loading.Please reload this page.
Relates to#10676
See discussion in#11033 (comment):
Migrating this to the proper type so it gets marshalled as a string and not a struct in the API.