- Notifications
You must be signed in to change notification settings - Fork928
chore: bump the offlinedocs group in /offlinedocs with 6 updates#11014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Parkreiner merged 3 commits intomainfromdependabot/npm_and_yarn/offlinedocs/offlinedocs-e453759cecDec 4, 2023
Merged
chore: bump the offlinedocs group in /offlinedocs with 6 updates#11014
Parkreiner merged 3 commits intomainfromdependabot/npm_and_yarn/offlinedocs/offlinedocs-e453759cecDec 4, 2023
+746 −585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Bumps the offlinedocs group in /offlinedocs with 6 updates:| Package | From | To || --- | --- | --- || [fs-extra](https://github.com/jprichardson/node-fs-extra) | `11.1.1` | `11.2.0` || [react-markdown](https://github.com/remarkjs/react-markdown) | `8.0.3` | `9.0.1` || [rehype-raw](https://github.com/rehypejs/rehype-raw) | `6.1.1` | `7.0.0` || [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `18.18.1` | `18.19.2` || [eslint](https://github.com/eslint/eslint) | `8.53.0` | `8.55.0` || [typescript](https://github.com/Microsoft/TypeScript) | `5.1.6` | `5.3.2` |Updates `fs-extra` from 11.1.1 to 11.2.0- [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md)- [Commits](jprichardson/node-fs-extra@11.1.1...11.2.0)Updates `react-markdown` from 8.0.3 to 9.0.1- [Release notes](https://github.com/remarkjs/react-markdown/releases)- [Changelog](https://github.com/remarkjs/react-markdown/blob/main/changelog.md)- [Commits](remarkjs/react-markdown@8.0.3...9.0.1)Updates `rehype-raw` from 6.1.1 to 7.0.0- [Release notes](https://github.com/rehypejs/rehype-raw/releases)- [Commits](rehypejs/rehype-raw@6.1.1...7.0.0)Updates `@types/node` from 18.18.1 to 18.19.2- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)Updates `eslint` from 8.53.0 to 8.55.0- [Release notes](https://github.com/eslint/eslint/releases)- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)- [Commits](eslint/eslint@v8.53.0...v8.55.0)Updates `typescript` from 5.1.6 to 5.3.2- [Release notes](https://github.com/Microsoft/TypeScript/releases)- [Commits](microsoft/TypeScript@v5.1.6...v5.3.2)---updated-dependencies:- dependency-name: fs-extra dependency-type: direct:production update-type: version-update:semver-minor dependency-group: offlinedocs- dependency-name: react-markdown dependency-type: direct:production update-type: version-update:semver-major dependency-group: offlinedocs- dependency-name: rehype-raw dependency-type: direct:production update-type: version-update:semver-major dependency-group: offlinedocs- dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: offlinedocs- dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: offlinedocs- dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: offlinedocs...Signed-off-by: dependabot[bot] <support@github.com>
Member
matifali commentedDec 4, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I have noticed we are using different typescript versions in |
Member
Parkreiner commentedDec 4, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yeah, I don't think we're really using any TypeScript features post-4.9 that would make the mismatch a huge deal, but it'd be nice to make things consistent Going through this, it looks like one of the main issues for the PR failing is that the the markdown libraries changed their types slightly:
|
Alrighty, I think things are finally fixed up. Also had to update how we were defining our links to avoid accessibility/server hydration issues As long as the CI passes this, I think it should be safe to merge in |
Parkreiner approved these changesDec 4, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the offlinedocs group in /offlinedocs with 6 updates:
11.1.111.2.08.0.39.0.16.1.17.0.018.18.118.19.28.53.08.55.05.1.65.3.2Updates
fs-extrafrom 11.1.1 to 11.2.0Changelog
Sourced fromfs-extra's changelog.
Commits
5d4bf0b11.2.0d293448perf: copy dir contents in parallel (#1026)a277cbbRefactormoveAPI to async/await (#1025)40c5161RefactorcopyAPI to async/await (#1021)6f2b2bcRefactorcreate*/ensure*API to async/await (#1023)426bb46RefactoroutputFileAPI to async/await (#1024)47bc43dSimplify reduce for checking match (#1016)Updates
react-markdownfrom 8.0.3 to 9.0.1Release notes
Sourced fromreact-markdown's releases.
... (truncated)
Changelog
Sourced fromreact-markdown's changelog.
... (truncated)
Commits
a27d3359.0.1d8e3787Fix double encoding in new url transform55d8d83Refactor docs to usecreateRoot2245c64Fix typobc09364Fix typos1d5cbf5Refactor some more5445cbbFix to close details6360bc29.0.072e68d2Add docs on line endingsb67d714Change to require Node.js 16Updates
rehype-rawfrom 6.1.1 to 7.0.0Release notes
Sourced fromrehype-raw's releases.
Commits
b3462997.0.09a794bbChange to require Node.js 16cd34249Change to useexportsa12b494Refactor docsb1e7f8eRefactor code-style29e486fRefactor to move implementation tolib/730e56eRefactor Actionsbb6d9b8Refactorpackage.json9dc61c4Refactortsconfig.jsoncdbb980Updatehast-util-raw,@types/hastUpdates
@types/nodefrom 18.18.1 to 18.19.2Commits
Updates
eslintfrom 8.53.0 to 8.55.0Release notes
Sourced fromeslint's releases.
Changelog
Sourced fromeslint's changelog.
Commits
e0cb9608.55.0969b272Build: changelog update for 8.55.0eb8950cchore: upgrade@eslint/js@8.55.0 (#17811)93df384chore: package.json update for@eslint/jsreleasefe4b954chore: upgrade@eslint/eslintrc@2.1.4 (#17799)8c9e6c1feat: importNamePattern option in no-restricted-imports (#17721)83ece2adocs: fix typo--rules->--rule(#17806)bd8911dci: pin Node.js 21.2.0 (#17809)b29a16bchore: fix severalclitests to run in the intended flat config mode (#17797)fffca5cdocs: remove "Open in Playground" buttons for removed rules (#17791)Updates
typescriptfrom 5.1.6 to 5.3.2Release notes
Sourced fromtypescript's releases.
... (truncated)
Commits
27047e3Update LKG.d09b1bfPick#56449 into release-5.3 (#56451)e2a5d45Update LKG.756efd2Fixes for release-5.3. (#56424)88f80c7Update LKG5823785Merge remote-tracking branch 'origin/main' into release-5.33e12250Allow of inawait usingdeclarations in for-of loops (#55558)b86883fBump version to 5.3.1-rc and LKGe2234f6Update LKG826bea9Merge remote-tracking branch 'origin/main' into release-5.3Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions