Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: fix TestWorkspaceAutobuild/DormantNoAutostart flake#10963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sreya merged 1 commit intomainfromjon/fixdormantflake
Nov 30, 2023

Conversation

sreya
Copy link
Collaborator

@sreyasreya commentedNov 30, 2023
edited
Loading

fixes#10947

The test forgets to reassign the updated workspace object after stopping the workspace so the build time that we use to pass to the autobuilder ticker is the one from initially starting the workspace. You would frequently get lucky because both builds would occur within the same hour. In this case the start build happened on (e.g.)01:59 and the stop build happened on02:00 so when we're calculating the next occurrence we're off by one hour.

@sreyasreya merged commit329aa45 intomainNov 30, 2023
@sreyasreya deleted the jon/fixdormantflake branchNovember 30, 2023 21:45
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 30, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@coadlercoadlercoadler approved these changes

Assignees

@sreyasreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: enterprise/coderd TestWorkspaceAutobuild/DormantNoAutostart
2 participants
@sreya@coadler

[8]ページ先頭

©2009-2025 Movatter.jp