Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

example: use ServiceAccount for k8s cluster authentication#1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bpmct merged 1 commit intokubesamplefrombpmct/kubesample-serviceaccount
May 11, 2022

Conversation

bpmct
Copy link
Member

@bpmctbpmct commentedApr 20, 2022
edited
Loading

This optionally allows users to authenticate to a Kubernetes cluster via a ServiceAccount, similar toworkspace providers in Coder v1.

This could potentially be another example since it makes the example significantly longer.

@bpmctbpmct requested a review fromkylecarbsApril 20, 2022 21:29
@bpmctbpmct self-assigned thisApr 20, 2022
@codecov
Copy link

codecovbot commentedApr 20, 2022
edited
Loading

Codecov Report

Merging#1096 (98b7d05) intokubesample (9dfcbe1) willdecrease coverage by9.18%.
The diff coverage isn/a.

@@              Coverage Diff               @@##           kubesample    #1096      +/-   ##==============================================- Coverage       66.47%   57.29%   -9.19%==============================================  Files             255      261       +6       Lines           15671    15674       +3       Branches          152      152              ==============================================- Hits            10417     8980    -1437- Misses           4187     5711    +1524+ Partials         1067      983      -84
FlagCoverage Δ
unittest-go-macos-latest53.29% <ø> (-0.18%)⬇️
unittest-go-postgres-?
unittest-go-ubuntu-latest55.84% <ø> (+0.02%)⬆️
unittest-go-windows-202252.85% <ø> (+0.02%)⬆️
unittest-js67.63% <ø> (+0.79%)⬆️
Impacted FilesCoverage Δ
coderd/database/queries.sql.go0.00% <0.00%> (-83.18%)⬇️
coderd/devtunnel/tunnel.go0.00% <0.00%> (-79.67%)⬇️
coderd/database/pubsub.go0.00% <0.00%> (-77.78%)⬇️
coderd/database/db.go0.00% <0.00%> (-55.18%)⬇️
coderd/database/migrate.go0.00% <0.00%> (-45.00%)⬇️
provisionersdk/transport.go78.72% <0.00%> (-6.39%)⬇️
coderd/httpapi/httpapi.go66.25% <0.00%> (-6.25%)⬇️
coderd/coderdtest/coderdtest.go93.80% <0.00%> (-5.08%)⬇️
cli/start.go57.56% <0.00%> (-4.48%)⬇️
provisionerd/provisionerd.go78.67% <0.00%> (-2.65%)⬇️
... and127 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update9dfcbe1...98b7d05. Read thecomment docs.

type = string
sensitive = true
description = <<-EOF
Use docs at https://github.com/coder/coder/tree/main/examples/kubernetes-multi-service#serviceaccount to create a ServiceAccount for Coder and grab values.
Copy link
MemberAuthor

@bpmctbpmctApr 20, 2022
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I had to link to the README because Terraform will force indent any text here and <<-EOF wasn't working with the double-spaced YAML to create a ServiceAccount on a cluster

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure we should promote this route right now, but until we have a better way I think it works just fine!

@bpmctbpmct merged commit371dde8 intokubesampleMay 11, 2022
@bpmctbpmct deleted the bpmct/kubesample-serviceaccount branchMay 11, 2022 18:19
bpmct added a commit that referenced this pull requestMay 11, 2022
* example: Add Kubernetes multi-service* fix: change to CODER_AGENT_TOKEN* example: use ServiceAccount for cluster authentication (#1096)Co-authored-by: Ben <ben@coder.com>
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
kylecarbs added a commit that referenced this pull requestJun 10, 2022
* example: Add Kubernetes multi-service* fix: change to CODER_AGENT_TOKEN* example: use ServiceAccount for cluster authentication (#1096)Co-authored-by: Ben <ben@coder.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

Assignees

@bpmctbpmct

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

3 participants
@bpmct@kylecarbs@misskniss

[8]ページ先頭

©2009-2025 Movatter.jp