- Notifications
You must be signed in to change notification settings - Fork928
chore: add external auth providers tooidctest#10958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Current dependencies on/for this PR:
Thisstack of pull requests is managed byGraphite. |
oidctestoidctest
johnstcn left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM,but I think at this point we need to add a EDIT: I see it now, never mind!*testing.T intoFakeIDP and startt.Log()-ing everywhere like crazy so we can debug these tests more easily.
Uh oh!
There was an error while loading.Please reload this page.
What this does
Enables external auth tests to use
oidctestpkg with a fake oauth provider. This makes external auth flows actually test against a functioning fake idp. I had to add some custom settings to the IDP to support the custom route additions.I did not touch the device flow because I do not 100% understand it.
Why?
Firstly using an actual IDP is just overall good for our tests. I am working on a different external auth thing, and want to use this.