Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: purge old provisioner daemons#10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 12 commits intomainfrom10676-prune-inactive
Dec 1, 2023
Merged

feat: purge old provisioner daemons#10949

mtojek merged 12 commits intomainfrom10676-prune-inactive
Dec 1, 2023

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedNov 30, 2023•
edited
Loading

Related:#10676

This PR extendsdbpurge to delete provisioner daemons under the following conditions:

  • provisioner daemon got registered at least 7 days ago
  • provisioner daemon reported its status (updated_at) 7 days ago or before

The feature should clean old provisioner daemon entries, seehttps://dev.coder.com/api/v2/organizations/703f72a1-76f6-4f89-9de6-8a3989693fe5/provisionerdaemons .

Other changes:

  • usedoTick pattern
  • run the first iteration immediately

@mtojekmtojek marked this pull request as ready for reviewNovember 30, 2023 14:04
@mtojek
Copy link
MemberAuthor

In the follow-up I try to coverdbpurge with dbmock tests.

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If we're making changes to the core dbpurge logic then we should add tests first before merging. I'm working on adding these now.

@mtojekmtojek marked this pull request as draftDecember 1, 2023 11:52
@mtojekmtojek marked this pull request as ready for reviewDecember 1, 2023 12:42
@mtojekmtojekenabled auto-merge (squash)December 1, 2023 12:43
@mtojekmtojek merged commit13b89f7 intomainDec 1, 2023
@mtojekmtojek deleted the 10676-prune-inactive branchDecember 1, 2023 12:43
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 1, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mtojekmtojek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtojek@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp