- Notifications
You must be signed in to change notification settings - Fork928
feat: adddismissed property to the healthcheck section#10940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dismissed property in a healthcheck sectiondismissed property to the healthcheck sectionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FE looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, some comments but nothing blocking. 👍
| dismissedHealthchecks := loadDismissedHealthchecks(ctx, options.Database, options.Logger) | ||
| return healthcheck.Run(ctx, &healthcheck.ReportOptions{ | ||
| Database: healthcheck.DatabaseReportOptions{ | ||
| DB: options.Database, | ||
| Threshold: options.DeploymentValues.Healthcheck.ThresholdDatabase.Value(), | ||
| Dismissed: slices.Contains(dismissedHealthchecks, healthcheck.SectionDatabase), | ||
| }, | ||
| Websocket: healthcheck.WebsocketReportOptions{ | ||
| AccessURL: options.AccessURL, | ||
| APIKey: apiKey, | ||
| Dismissed: slices.Contains(dismissedHealthchecks, healthcheck.SectionWebsocket), | ||
| }, | ||
| AccessURL: healthcheck.AccessURLReportOptions{ | ||
| AccessURL: options.AccessURL, | ||
| Dismissed: slices.Contains(dismissedHealthchecks, healthcheck.SectionAccessURL), | ||
| }, | ||
| DerpHealth: derphealth.ReportOptions{ | ||
| DERPMap: api.DERPMap(), | ||
| DERPMap: api.DERPMap(), | ||
| Dismissed: slices.Contains(dismissedHealthchecks, healthcheck.SectionDERP), | ||
| }, | ||
| WorkspaceProxy: healthcheck.WorkspaceProxyReportOptions{ | ||
| CurrentVersion: buildinfo.Version(), | ||
| WorkspaceProxiesFetchUpdater: *(options.WorkspaceProxiesFetchUpdater).Load(), | ||
| Dismissed: slices.Contains(dismissedHealthchecks, healthcheck.SectionWorkspaceProxy), | ||
| }, | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
non-blocking: this anonymous function is getting a bit heavy-weight and could probably use a refactor of some sort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ack
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fixes:#10712
The last part of backend implementation. The
dismissedproperty is present in everyhealth check section.