- Notifications
You must be signed in to change notification settings - Fork928
example: Add Kubernetes multi-service#1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedApr 19, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1092 +/- ##==========================================+ Coverage 66.55% 66.95% +0.40%========================================== Files 261 284 +23 Lines 15674 18657 +2983 Branches 152 241 +89 ==========================================+ Hits 10432 12492 +2060- Misses 4176 4893 +717- Partials 1066 1272 +206
Continue to review full report at Codecov.
|
What are your thoughts on including a PVC in this example? We can mount a PVC to multiple containers, I did it for your examplehere, but we loose all the nice ZSH stuff from the devcontainer |
| container { | ||
| name = "go" | ||
| image = "mcr.microsoft.com/vscode/devcontainers/go:1" | ||
| command = ["sh", "-c", coder_agent.go.init_script] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've noticed all of these containers bring you to strange locations when you ssh in for the first time
go:/go
java:/
ubuntu/
Should the init script always do something likecd $HOME before it starts the agent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It will in my other PR now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This worked great, I submitted#1096 to add optional auth via ServiceAccount. Also left a comment about PVC support in this example. All your call
I think we'll have to do cleanup on the templates to make the names apt anyways, so I'll just leave this without volumes and such for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@kylecarbs I think this is good to go, but could you look at#1096 before merging?
* example: Add Kubernetes multi-service* fix: change to CODER_AGENT_TOKEN* example: use ServiceAccount for cluster authentication (#1096)Co-authored-by: Ben <ben@coder.com>
No description provided.