Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: include health severity in reports#10817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 21 commits intomainfrom9754-severity
Nov 23, 2023
Merged

feat: include health severity in reports#10817

mtojek merged 21 commits intomainfrom9754-severity
Nov 23, 2023

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedNov 21, 2023•
edited
Loading

Fixes:#9754

This PR addsseverity enum (ok, warning, error) to health reports, and modifies rules based on which severity level is selected.

Rules:

  • AccessURL: Warning if the endpoint is responding but it isn't HTTP 200
  • Database: Warning if the latency threshold is breached, but database is responding
  • DERP: Warning if one node in the region is unhealthy
  • DERP: Use highest severity for the region if more than 1 node is unhealthy
  • DERP: Warning if users must use WebSockets

@mtojekmtojek self-assigned thisNov 21, 2023
@mtojekmtojek marked this pull request as ready for reviewNovember 22, 2023 19:04
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

just one nit about potential nil, otherwise LGTM

@mtojekmtojek merged commit78df683 intomainNov 23, 2023
@mtojekmtojek deleted the 9754-severity branchNovember 23, 2023 15:08
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 23, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

health check: severity levels
2 participants
@mtojek@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp