NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

refactor: Rename Icons and add stories#1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

presleyp merged 7 commits intomainfromicons/presleyp/938

Apr 19, 2022

Merged

refactor: Rename Icons and add stories#1080

presleyp merged 7 commits intomainfromicons/presleyp/938

Apr 19, 2022

Conversation

Copy link

Contributor

presleyp commentedApr 19, 2022•
edited
Loading

rename all icons to end in Icon except Logo
get rid of icons index file
replace icons test with stories

presleyp added6 commits

April 19, 2022 15:30

Rename CloseIcon

eca859a

Rename FileCopyIcon, take out of index

4ed892d

Rename LogoutIcon and remove from index

ff6ce60

Delete icons index files

b6b21a9

Add icon stories

f398003

Lint

7f97a5e

presleyp requested a review froma team as acode owner

April 19, 2022 16:05

presleyp self-assigned this

Apr 19, 2022

Copy link

Collaborator

BrunoQuaresma commentedApr 19, 2022

Should we update the stories filenames to beLogoIcon.stories.tsx as well?

Copy link

codecovbot commentedApr 19, 2022•
edited
Loading

Codecov Report

Merging#1080 (1c059a9) intomain (b9933d4) willdecrease coverage by0.03%.
The diff coverage is85.71%.

@@            Coverage Diff             @@##             main    #1080      +/-   ##==========================================- Coverage   66.58%   66.54%   -0.04%==========================================  Files         262      258       -4       Lines       15660    15471     -189       Branches      152      152              ==========================================- Hits        10427    10295     -132+ Misses       4164     4127      -37+ Partials     1069     1049      -20

Flag	Coverage Δ
unittest-go-macos-latest	`53.47% <ø> (+0.12%)`	⬆️
unittest-go-postgres-	`65.83% <ø> (+0.07%)`	⬆️
unittest-go-ubuntu-latest	`55.89% <ø> (+0.08%)`	⬆️
unittest-go-windows-2022	`?`
unittest-js	`67.63% <85.71%> (-0.34%)`	⬇️

Impacted Files	Coverage Δ
site/src/components/Icons/CloseIcon.tsx	`100.00% <ø> (ø)`
site/src/components/Icons/LogoutIcon.tsx	`100.00% <ø> (ø)`
site/src/components/Button/CopyButton.tsx	`52.38% <50.00%> (ø)`
site/src/components/Form/FormCloseButton.tsx	`100.00% <100.00%> (ø)`
site/src/components/Icons/FileCopyIcon.tsx	`100.00% <100.00%> (ø)`
site/src/components/Navbar/NavbarView/index.tsx	`93.33% <100.00%> (ø)`
site/src/components/Navbar/UserDropdown/index.tsx	`96.15% <100.00%> (ø)`
site/src/components/SignIn/Welcome.tsx	`100.00% <100.00%> (ø)`
site/src/components/Icons/WorkspacesIcon.tsx	`0.00% <0.00%> (-100.00%)`	⬇️
cli/configssh.go	`61.41% <0.00%> (-7.09%)`	⬇️
... and11 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb9933d4...1c059a9. Read thecomment docs.