- Notifications
You must be signed in to change notification settings - Fork1k
chore: move moons out of experimental mode#10716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This was in experimental for a long time.
This should be reopened |
| t.Parallel() | ||
| dv:=coderdtest.DeploymentValues(t) | ||
| dv.Experiments= []string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why keep the deployment values if you're not setting any experiments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In a lot of places....
| // Use proxy health to return the healthy workspace proxy hostnames. | ||
| f:=api.ProxyHealth.ProxyHosts | ||
| api.AGPL.WorkspaceProxyHostsFn.Store(&f) | ||
| // Proxy health is a moon feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| // Proxy health is a moon feature. |
| Network | ||
| </SidebarNavItem> | ||
| {dashboard.experiments.includes("moons")&&( | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should be removed
rebased on |
This was in experimental for a long time.