- Notifications
You must be signed in to change notification settings - Fork928
chore: replace todos with issues#1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedApr 19, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1066 +/- ##======================================= Coverage 66.79% 66.80% ======================================= Files 262 262 Lines 15653 15660 +7 Branches 152 152 =======================================+ Hits 10456 10462 +6- Misses 4136 4137 +1 Partials 1061 1061
Continue to review full report at Codecov.
|
| @@ -35,7 +35,6 @@ endif | |||
| .PHONY: fmt/prettier | |||
| fmt/sql:$(wildcard coderd/database/queries/*.sql) | |||
| # TODO: this is slightly slow | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| @@ -3,8 +3,6 @@ package usershell | |||
| import"os" | |||
| // Get returns the $SHELL environment variable. | |||
| // TODO: This should use "dscl" to fetch the proper value. See: | |||
| // https://stackoverflow.com/questions/16375519/how-to-get-the-default-shell | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| @@ -22,7 +22,7 @@ func workspaceAutostart() *cobra.Command { | |||
| Short:"schedule a workspace to automatically start at a regular time", | |||
| Long:autostartDescriptionLong, | |||
| Example:"coder workspaces autostart enable my-workspace --minute 30 --hour 9 --days 1-5 --tz Europe/Dublin", | |||
| Hidden:true,// TODO(cian): un-hide when autostart scheduling implemented | |||
| Hidden:true, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| @@ -22,7 +22,7 @@ func workspaceAutostop() *cobra.Command { | |||
| Short:"schedule a workspace to automatically stop at a regular time", | |||
| Long:autostopDescriptionLong, | |||
| Example:"coder workspaces autostop enable my-workspace --minute 0 --hour 18 --days 1-5 -tz Europe/Dublin", | |||
| Hidden:true,// TODO(cian): un-hide when autostop scheduling implemented | |||
| Hidden:true, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| @@ -20,8 +20,6 @@ type Role struct { | |||
| Namestring`json:"name"` | |||
| Site []Permission`json:"site"` | |||
| // Org is a map of orgid to permissions. We represent orgid as a string. | |||
| // TODO: Maybe switch to uuid, but tokens might need to support a "wildcard" org | |||
| //which could be a special uuid (like all 0s?) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| @@ -49,7 +47,6 @@ var ( | |||
| RoleAuditor=Role{ | |||
| Name:"auditor", | |||
| Site:permissions(map[Object][]Action{ | |||
| // TODO: @emyrk when audit logs are added, add back a read perm | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| //be pooled so synchronously, but is definitely possible. | ||
| //REMARK: There's an obvious race-condition here. This is an edge-case, as | ||
| //most-frequently data won't be pooled so synchronously, but is | ||
| // definitely possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| @@ -270,8 +270,6 @@ func secureHeaders(next http.Handler) http.Handler { | |||
| // Only scripts can manipulate the dom. This prevents someone from | |||
| // naming themselves something like '<svg onload="alert(/cross-site-scripting/)" />'. | |||
| // TODO: @emyrk we need to make FE changes to enable this. We get 'TrustedHTML' and 'TrustedURL' errors | |||
| //that require FE changes to work. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| // workspaces per-template. This just grabs all workspaces... and then | ||
| // later filters them to match the current template. | ||
| // This just grabs all workspaces... and then later filters them to match the | ||
| // current template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Uh oh!
There was an error while loading.Please reload this page.
Resolves:#971