- Notifications
You must be signed in to change notification settings - Fork928
feat: add customizable ttl_bump interval#10566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Emyrk commentedNov 9, 2023
Comment on lines +5 to +10
| ALTER TABLE templates ADD COLUMN default_ttl_bump bigint DEFAULT '0'::bigint NOT NULL; | ||
| COMMENT ON COLUMN templates.default_ttl_bump IS 'Amount of time to bump workspace ttl from activity. 0 will default to the "default_ttl" as the bump interval.'; | ||
| ALTER TABLE workspaces ADD COLUMN ttl_bump bigint DEFAULT '0'::bigint NOT NULL; | ||
| COMMENT ON COLUMN workspaces.ttl_bump IS 'Amount of time to bump workspace ttl from activity. 0 will default to the "ttl" as the bump interval.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
0 means defer tottl for the bump interval.
This is awesome |
Actually changing this up in favor of something more simple. |
Closed for#10704 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closed for#10704
If
ttl_bumpis set, allows the activity of a workspace to bump the TTL by some other amount than the defaut TTL.Example being, if you have autostop set to 8hrs, then the workspace deadline is set to 8hrs.
When the workspace has any activity, the deadline increases by 8hrs. If done at the last minute, this means the deadline is 16hours out from the original amount.
This PR allows setting the autostop to 8hrs, with activity bumping the deadline by a smaller amount, such as 1 hour.
This is especially useful for long autostops.
By default ttl_bump is set to 0 anddoes nothing
UI
Peek.2023-11-13.12-09.webm
Closeshttps://github.com/coder/customers/issues/318