- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: upgrade tailscale to fix STUN probes on dual stack#10535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix: upgrade tailscale to fix STUN probes on dual stack#10535
Uh oh!
There was an error while loading.Please reload this page.
Conversation
spikecurtis commentedNov 6, 2023
Current dependencies on/for this PR: Thisstack of pull requests is managed byGraphite. |
3c432d4 to0bdc2dfCompare| assert.NotEmpty(t,node.RoundTripPing) | ||
| assert.Len(t,node.ClientLogs,2) | ||
| assert.Len(t,node.ClientLogs[0],1) | ||
| assert.Len(t,node.ClientLogs[0],3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
note: extra logs come fromcoder/tailscale#41
| }) | ||
| t.Run("ForceWebsockets",func(t*testing.T) { | ||
| t.Run("FailoverToWebsockets",func(t*testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"ForceWebsockets" is a setting that makes it not even attempt regular DERP upgrade. Here we try Upgrade: DERP, get rejected, and then failover to websockets.
Fixes STUN probe issues on dual stack systems by incorporatingcoder/tailscale#43