- Notifications
You must be signed in to change notification settings - Fork928
ci: Don't run internal steps if forked#1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
.github/workflows/coder.yaml Outdated
| @@ -184,7 +184,7 @@ jobs: | |||
| -timeout=3m -count=$GOCOUNT -short -failfast | |||
| - name: Upload DataDog Trace | |||
| if: (success() || failure()) && github.actor != 'dependabot[bot]' && github.repository_owner == 'coder' | |||
| if: (success() || failure()) && github.actor != 'dependabot[bot]' &&!github.event.pull_request.head.repo.fork | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would it be better to check if the secret is empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Apparently you can't...actions/runner#520
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Well, you can. It's just janky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Unlucky
codecovbot commentedApr 15, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1045 +/- ##===========================================- Coverage 67.48% 56.26% -11.23%=========================================== Files 259 133 -126 Lines 15059 13464 -1595 Branches 151 0 -151 ===========================================- Hits 10162 7575 -2587- Misses 3881 5006 +1125+ Partials 1016 883 -133
Continue to review full report at Codecov.
|
.github/workflows/coder.yaml Outdated
| @@ -184,7 +184,7 @@ jobs: | |||
| -timeout=3m -count=$GOCOUNT -short -failfast | |||
| - name: Upload DataDog Trace | |||
| if: (success() || failure()) && github.actor != 'dependabot[bot]' && github.repository_owner == 'coder' | |||
| if: (success() || failure()) && github.actor != 'dependabot[bot]' &&!github.event.pull_request.head.repo.fork | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also random thought,(success() || failure()) can just bealways()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good point. Will change
This was causing CI to fail for contributions.
Did you mean to merge this? |
Nah nah I opened this as a fork instead just to confirm it works |
This was causing CI to fail for contributions.