- Notifications
You must be signed in to change notification settings - Fork928
fix: disable t.Parallel on TestPortForward#10449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Current dependencies on/for this PR: Thisstack of pull requests is managed byGraphite. |
mafredri approved these changesNov 1, 2023
Uh oh!
There was an error while loading.Please reload this page.
Merge activity
|
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've said it before, I'll say it again: you can't create a timed context before calling
t.Parallel()and then use it after.Fixes flakes likehttps://github.com/coder/coder/actions/runs/6716682414/job/18253279157
I've chosen just to drop
t.Parallel()entirely rather than create a second context after the parallel call, since the vast majority of the test time happens before where the parallel call was. It does all the tailnet setup beforet.Parallel().Leaving a call to
t.Parallel()is a bug risk for future maintainers to come in and use the wrong context in the latter part of the test by accident.